[release/7.0] Allow shared columns with nullable value converters#29778
Merged
Conversation
AndriySvyryd
force-pushed
the
Issue29531_7.0
branch
from
5666a53 to
61523be
Compare
ajcvickers
approved these changes
Dec 5, 2022
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port of #29746
Fixes #29531
Description
The logic for verifying the compatibility of two properties sharing a column does not work when one of them has a value converter to a nullable value type.
Customer impact
Affected models will always throw an exception. There is no workaround that would preserve the functionality of the value converter.
How found
Customer reported on 7.0
Regression
Yes.
Testing
Added a test for the affected scenario.
Risk
Low; the fix only affects scenarios with shared columns that involve value converters, and a quirk was added to revert back to older behavior.