Skip to content

Add interception for DbDataReader.Close #28290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2022
Merged

Add interception for DbDataReader.Close #28290

merged 1 commit into from
Jun 23, 2022

Conversation

ajcvickers
Copy link
Contributor

Part of #626
Fixes #23535

Also added tests to:

@ajcvickers
Add interception for DbDataReader.Close
c2f69ab 
Part of #626
Fixes #23535

Also added tests to:
 - Show that this can be used to get statistics from a query, as requested in #23535.
 - Show that Close and/or Dispose can be suppressed, as requested in #24295.
@ajcvickers ajcvickers requested a review from a team June 21, 2022 20:21
@ajcvickers ajcvickers merged commit 62fb246 into main Jun 23, 2022
@ajcvickers ajcvickers deleted the DisposableClosable0621 branch June 23, 2022 21:31
@ajcvickers ajcvickers mentioned this pull request Jul 7, 2022
Closed
@MaceWindu MaceWindu mentioned this pull request Aug 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add interception event to be fired when EF has finished consuming a result set
2 participants
@ajcvickers @AndriySvyryd