Static analysis: minor small changes #26946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
reviewed
Dec 8, 2021
| @@ -951,8 +949,7 @@ private Expression GetGroupingKey(Expression key, List<Expression> groupingExpre | |||
|
|
|||
| innerQueryExpression._clientProjections.Clear(); | |||
|
|
|||
| innerShaperExpression = | |||
| new ProjectionIndexRemappingExpressionVisitor(innerQueryExpression, this, indexMap).Visit(innerShaperExpression); | |||
| new ProjectionIndexRemappingExpressionVisitor(innerQueryExpression, this, indexMap).Visit(innerShaperExpression); | |||
There was a problem hiding this comment.
It's strange that the results are not used.
@smitpatel
There was a problem hiding this comment.
the next line throws exception so this code path is not yet used. 
There was a problem hiding this comment.
We should either undo the changes to remove this code
There was a problem hiding this comment.
I wondered if the visitor might throw a different exception in some cases, and hence the code "does something" even though the next line is never reached. Nevertheless, I have reverted the change here.
AndriySvyryd
approved these changes
Dec 8, 2021
ajcvickers
force-pushed
the
InspectorThursday1208
branch
from
9c0ff2c
to
9ab4cad
Compare
Part of #26805 For example: - Assignment is not used - Redundant discard - Redundant explicit size in array creation - Convert field to local - Redundant verbatim prefix - Redundant lambda parens
ajcvickers
force-pushed
the
InspectorThursday1208
branch
from
9ab4cad
to
bbbd6f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #26805
For example: