[6.0.1] Use a unique identifier for variables during insert #26679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
approved these changes
Nov 15, 2021
AndriySvyryd
changed the title
ajcvickers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26632
Description
When the entity types have store-generated primary keys invalid SQL is produced when a single entity of one type as well as 3 or more (or the amount specified in
MinBatchSize) are inserted together.Customer impact
SaveChangesproduces invalid SQL that results in an exception. The workaround would be to callSaveChangesafter each batch of specific entity type is added, but this isn't always practical.How found
Customer reported on 6.0
Regression
Yes, this worked in 5.0. Introduced in #25718
Testing
Added test for this scenario.
Risk
Low, the change has very predictable impact. Also added a quirk mode.