[6.0] Fix to #26166 - Idempotent migration script generates problematic temporal table alter statement #26193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
changed the title
|
@Pilchie for approval - low risk fix (adding exec around a sql statement) in a new feature (temporal tables). issue has recently been found by a customer |
maumar
commented
Sep 28, 2021
| .Append(")") | ||
| .ToString(); | ||
|
|
||
| if (options.HasFlag(MigrationsSqlGenerationOptions.Idempotent)) |
There was a problem hiding this comment.
I tested disable period, as well as enable/disable versioning - they all work. Only enable period causes issues it seems
|
Scenario approved for EFCore 6.0, pending code review sign-off. |
AndriySvyryd
approved these changes
Sep 29, 2021
…poral table alter statement Problem was that for idempotent migration scripts that convert non-temporal table to temporal we need to wrap the period switching statement in exec. Otherwise sql parser(?) complains that the command is invalid because period already exists. This is a false negative - the statement will not actually execute if this migration has already been applied. Exec fixes the problem since the statement inside it can't be parsed. This is how we deal with similar issues in other places in the code. Fixes #26166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was that for idempotent migration scripts that convert non-temporal table to temporal we need to wrap the period switching statement in exec. Otherwise sql parser(?) complains that the command is invalid because period already exists. This is a false negative - the statement will not actually execute if this migration has already been applied. Exec fixes the problem since the statement inside it can't be parsed. This is how we deal with similar issues in other places in the code.
Fixes #26166