[6.0] Fix to #26084 - Query: SqlExpressionFactory doesn't apply type mapping to InExpression #26153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
changed the title
maumar
commented
Sep 23, 2021
| : inExpression; | ||
| } | ||
|
|
||
| return item != inExpression.Item || inExpression.TypeMapping != _boolTypeMapping |
There was a problem hiding this comment.
do we need to do something about subquery case? Or will Select always have proper mappings? (since the ctor is not public) @smitpatel
ajcvickers
changed the title
smitpatel
reviewed
Sep 27, 2021
smitpatel
approved these changes
Sep 27, 2021
|
@Pilchie for approval into 6.0 - low risk, low impact issue |
|
Approved for EFCore 6.0 |
…g to InExpression We were not applying mapping to InExpression and it's constituents which could lead to failed translations when these expressions were constructed manually (e.g. as part of UDF translation) Fixes #26084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not applying mapping to InExpression and it's constituents which could lead to failed translations when these expressions were constructed manually (e.g. as part of UDF translation)
Fixes #26084