Update the entity type on check constraints when it's converted to a STET #26112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
Issue23399
branch
from
b6569c3
to
1a0191f
Compare
AndriySvyryd
force-pushed
the
Issue23399
branch
from
1a0191f
to
0fe517c
Compare
|
@Pilchie For approval |
|
Approved for EFCore 6.0 pending code review and CI passing. |
bricelam
approved these changes
Sep 21, 2021
src/EFCore.Relational/Metadata/Conventions/CheckConstraintConvention.cs
Outdated
Show resolved
Hide resolved
…ention.cs Co-authored-by: Brice Lambson <brice@bricelam.net>
AndriySvyryd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23399
Description
Currently when an entity type is converted to a shared-type entity type the check constraints are just copied over, without updating the back reference to the entity type.
Customer impact
Without this fix migrations throw an error when performing the diff.
How found
Customer
Regression
No.
Testing
Test for this scenario added in the PR.
Risk
Low, the modified code only affects STETs with check constraints - a relatively rare scenario.