[6.0-rc2] RevEng: Generate correct FK configuration for scaffolding #26087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @Pilchie |
|
|
|
Wrong issue. Not approved. :-) |
ajcvickers
approved these changes
Sep 17, 2021
|
Really approved now. |
AndriySvyryd
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26086
Description
Code scaffolded for many-to-many join table is configuring wrong FKs for join table.
Customer Impact
An exception is thrown for entities with different key types on either end of the relationship. This is how it was discovered. It could cause silent data corruption for the more common case where entities have the same key type.
How found
Customer reported on RC1.
Test coverage
Added regression tests for the scenario. Also manually tested scaffolding Northwind database where issue was found. We also have #25543 tracking better coverage in general for this area.
Regression?
No. This is new feature in 6.0
Risk
Low. Since the scenario was fully broken, this doesn't have potential to make it worse. Testing on Northwind database also gives us confidence that we are correcting bug here.