Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate same filters in duplicate indexes #25931

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

roji
Copy link
Member

@roji roji commented Sep 8, 2021

Fixes #24968

@roji roji requested a review from a team September 8, 2021 11:03
@roji roji merged commit 1087a73 into release/6.0 Sep 8, 2021
@roji roji deleted the roji/ValidateIndexFilters branch September 8, 2021 16:32
@@ -85,6 +85,20 @@ public static class RelationalIndexExtensions
return false;
}

if (index.GetFilter() != duplicateIndex.GetFilter())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

            if (index.GetFilter(storeObject) != duplicateIndex.GetFilter(storeObject))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/me goes and hides under a rock!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows to skip filter configuration for the index on the dependent in table sharing, avoiding a breaking change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, will submit a fixup.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roji added a commit that referenced this pull request Sep 8, 2021
roji added a commit that referenced this pull request Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate that filters are the same for shared indexes
3 participants