Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change logging level for non-created indexes from Info to Warn #25928

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Change logging level for non-created indexes from Info to Warn #25928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/EFCore.Relational/Properties/RelationalStrings.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/EFCore.Relational/Properties/RelationalStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@
</data>
<data name="LogNamedIndexAllPropertiesNotToMappedToAnyTable" xml:space="preserve">
<value>The index named '{indexName}' on the entity type '{entityType}' specifies properties {indexProperties}, but none of these properties are mapped to a column in any table. This index will not be created in the database.</value>
<comment>Information RelationalEventId.AllIndexPropertiesNotToMappedToAnyTable string? string string</comment>
<comment>Warning RelationalEventId.AllIndexPropertiesNotToMappedToAnyTable string? string string</comment>
</data>
<data name="LogNamedIndexPropertiesBothMappedAndNotMappedToTable" xml:space="preserve">
<value>The index named '{indexName}' on the entity type '{entityType}' specifies properties {indexProperties}. Some properties are mapped to a column in a table, but the property '{propertyName}' is not. All of the properties must be mapped for the index to be created in the database.</value>
Expand Down Expand Up @@ -619,7 +619,7 @@
</data>
<data name="LogUnnamedIndexAllPropertiesNotToMappedToAnyTable" xml:space="preserve">
<value>The unnamed index on the entity type '{entityType}' specifies properties {indexProperties}, but none of these properties are mapped to a column in any table. This index will not be created in the database.</value>
<comment>Information RelationalEventId.AllIndexPropertiesNotToMappedToAnyTable string string</comment>
<comment>Warning RelationalEventId.AllIndexPropertiesNotToMappedToAnyTable string string</comment>
</data>
<data name="LogUnnamedIndexPropertiesBothMappedAndNotMappedToTable" xml:space="preserve">
<value>The unnamed index on the entity type '{entityType}' specifies properties {indexProperties}. Some properties are mapped to a column in a table, but the property '{propertyName}' is not. All of the properties must be mapped for the index to be created in the database.</value>
Expand Down
6 changes: 2 additions & 4 deletions test/EFCore.Relational.Tests/Infrastructure/RelationalModelValidatorTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1930,8 +1930,7 @@ public void Passes_for_unnamed_index_with_all_properties_not_mapped_to_any_table
definition.GenerateMessage(
nameof(Animal),
"{'Id', 'Name'}"),
modelBuilder,
LogLevel.Information);
modelBuilder);
}

[ConditionalFact]
Expand All @@ -1953,8 +1952,7 @@ public void Passes_for_named_index_with_all_properties_not_mapped_to_any_table()
"IX_AllPropertiesNotMapped",
nameof(Animal),
"{'Id', 'Name'}"),
modelBuilder,
LogLevel.Information);
modelBuilder);
}

[ConditionalFact]
Expand Down