Fix to #24671 - Relational: No tests for TranslateContains path #25768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
approved these changes
Aug 30, 2021
All Contains calls are converted to Any with predicate (which allows to handle null semantics) so this code never gets but fixing this tiny bug, just in case. We were not setting the cardinality of the contains translation to single result, so the translation would have failed, if it wasn't converted to Any and therefore (correctly) being handled by it's translation code. Fixes #24671
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Contains calls are converted to Any with predicate (which allows to handle null semantics) so this code never gets but fixing this tiny bug, just in case. We were not setting the cardinality of the contains translation to single result, so the translation would have failed, if it wasn't converted to Any and therefore (correctly) being handled by it's translation code.
Fixes #24671