Reenable previously flaky Union_non_entity #25705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This also happens locally. You can run tests in the loop in local machine. |
|
That's also happening :) |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
OK, I left EFCore.SqlServer.FunctionalTests running all night long in a loop without failures, and we have 4 successful CI runs here too. I propose we merge this - if we get this failure again we can always disable the test again and investigate. |
ajcvickers
approved these changes
Aug 26, 2021
|
🤞 🤞 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing whether this will triggers weird flakiness