Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable nullability in migrations (RC1) #25629

Merged
1 commit merged into from
Aug 20, 2021
Merged

Conversation

roji
Copy link
Member

@roji roji commented Aug 20, 2021

Closes #25624

Merged #25626 for RC1
Fixes #25624

@roji roji requested a review from a team August 20, 2021 19:03
@ajcvickers
Copy link
Member

Why didn't you just put this in RC1 straight away? Then you only need one PR...

@roji roji linked an issue Aug 20, 2021 that may be closed by this pull request
@roji
Copy link
Member Author

roji commented Aug 20, 2021

Will do this next time, it's just not how my head works...

@ghost
Copy link

ghost commented Aug 20, 2021

Hello @roji!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 247a2cf into MergeRC1 Aug 20, 2021
@ghost ghost deleted the roji/NullableDisableMigrationsRC1 branch August 20, 2021 20:10
@AndriySvyryd
Copy link
Member

This wasn't targeting the right branch. It's NOT merged to rc1.

@roji
Copy link
Member Author

roji commented Aug 20, 2021

sigh sorry, will resubmit.

@roji roji restored the roji/NullableDisableMigrationsRC1 branch August 20, 2021 20:32
@roji roji deleted the roji/NullableDisableMigrationsRC1 branch August 20, 2021 20:32
@roji roji restored the roji/NullableDisableMigrationsRC1 branch August 20, 2021 20:32
@roji roji deleted the roji/NullableDisableMigrationsRC1 branch August 20, 2021 20:32
@roji
Copy link
Member Author

roji commented Aug 20, 2021

Opened #25633 against release/6.0-rc1

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable reference nullability in migrations and model snapshot
3 participants