Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrations Bundles: Address API Review feedback #25580

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Migrations Bundles: Address API Review feedback #25580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/EFCore.Tools/tools/EntityFrameworkCore.PS2.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ function Add-Migration(
.PARAMETER SelfContained
Also bundle the .NET runtime so it doesn't need to be installed on the machine.

.PARAMETER Runtime
.PARAMETER TargetRuntime
The target runtime to bundle for.

.PARAMETER Configuration
Expand Down Expand Up @@ -95,7 +95,7 @@ function Bundle-Migration(
$Output,
[switch] $Force,
[switch] $SelfContained,
$Runtime,
$TargetRuntime,
$Configuration,
$Framework,
$Context,
Expand Down
10 changes: 5 additions & 5 deletions src/EFCore.Tools/tools/EntityFrameworkCore.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ Register-TabExpansion Bundle-Migration @{
.PARAMETER SelfContained
Also bundle the .NET runtime so it doesn't need to be installed on the machine.

.PARAMETER Runtime
.PARAMETER TargetRuntime
The target runtime to bundle for.

.PARAMETER Configuration
Expand Down Expand Up @@ -152,7 +152,7 @@ function Bundle-Migration
[string] $Output,
[switch] $Force,
[switch] $SelfContained,
[string] $Runtime,
[string] $TargetRuntime,
[string] $Configuration,
[string] $Framework,
[string] $Context,
Expand Down Expand Up @@ -185,14 +185,14 @@ function Bundle-Migration
$params += '--self-contained'
}

if ($Runtime)
if ($TargetRuntime)
{
$params += '--bundle-runtime', $Runtime
$params += '--target-runtime', $TargetRuntime
}

if ($Configuration)
{
$params += '--bundle-configuration', $Configuration
$params += '--target-configuration', $Configuration
}

$params += GetParams $Context
Expand Down
4 changes: 2 additions & 2 deletions src/ef/Commands/MigrationsBundleCommand.Configure.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ public override void Configure(CommandLineApplication command)
_output = command.Option("-o|--output <FILE>", Resources.MigrationsBundleOutputDescription);
_force = command.Option("-f|--force", Resources.DbContextScaffoldForceDescription);
_selfContained = command.Option("--self-contained", Resources.SelfContainedDescription);
_runtime = command.Option("-r|--bundle-runtime <RUNTIME_IDENTIFIER>", Resources.MigrationsBundleRuntimeDescription);
_configuration = command.Option("--bundle-configuration <CONFIGURATION>", Resources.MigrationsBundleConfigurationDescription);
_runtime = command.Option("-r|--target-runtime <RUNTIME_IDENTIFIER>", Resources.MigrationsBundleRuntimeDescription);
_configuration = command.Option("--target-configuration <CONFIGURATION>", Resources.MigrationsBundleConfigurationDescription);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna look at removing this and flowing it from the project in a later PR


base.Configure(command);
}
Expand Down
2 changes: 1 addition & 1 deletion src/ef/Commands/MigrationsBundleCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ protected override int Execute(string[] args)

var outputPath = _output!.HasValue()
? _output!.Value()!
: "bundle" + exe;
: "efbundle" + exe;
var bundleName = Path.GetFileNameWithoutExtension(outputPath);

File.WriteAllText(
Expand Down