Allow execution strategy bypass #25041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not throw an exception on the first execution of an execution strategy if a transaction is pending when MaxRetryCount is zero. Addresses dotnet#24922.
AndriySvyryd
reviewed
Jun 9, 2021
| || Dependencies.CurrentContext.Context.Database.GetEnlistedTransaction() is not null | ||
| || (((IDatabaseFacadeDependenciesAccessor)Dependencies.CurrentContext.Context.Database).Dependencies.TransactionManager as | ||
| ITransactionEnlistmentManager)?.CurrentAmbientTransaction is not null) | ||
| if (RetriesOnFailure) |
There was a problem hiding this comment.
Combine with next if to avoid nesting.
AndriySvyryd
approved these changes
Jun 9, 2021
Combine with the if to avoid nesting and resolve PR feedback.
|
Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not throw an exception on the first execution of an execution strategy if a transaction is pending when
MaxRetryCountis zero.This follows the suggested implementation in #24922 (comment).
I've added a unit test for the async and sync execution paths using the example code in #24922 as the starting point.