-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't remove default table mapping for TVF return entity types. #25034
Conversation
test/EFCore.Design.Tests/Migrations/Design/CSharpMigrationsGeneratorTest.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like it's abusing Code.UnknownLiteral()
. I wonder if we need a new method like Code.NullableLiteral(value, compilerInfersType: false)
. But I'm ok with it as is for now.
b6732af
to
48d9fb3
Compare
Preserve null mappings in the model snapshot. Add non-generic ToSqlQuery overload. Output Fluent API for ToSqlQuery in the model snapshot. Fix SetFunctionName setting incorrect annotation. Fixes #23408
Hello @AndriySvyryd! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
Preserve
null
mappings in the model snapshot.Add non-generic
ToSqlQuery
overload.Output Fluent API for
ToSqlQuery
in the model snapshot.Fix
SetFunctionName
setting incorrect annotation.Fixes #23408