Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional dependent null #24856

Merged
merged 29 commits into from
May 31, 2021
Merged

Optional dependent null #24856

merged 29 commits into from
May 31, 2021

Conversation

umitkavala
Copy link
Contributor

No description provided.

@umitkavala umitkavala mentioned this pull request May 8, 2021
Closed
@umitkavala umitkavala marked this pull request as ready for review May 15, 2021 16:14
@AndriySvyryd
Copy link
Member

Add to TPTTableSplittingSqlServerTest:

[ConditionalFact(Skip = "Issue #24970")]
public override Task Can_insert_dependent_with_just_one_parent()
{
    return base.Can_insert_dependent_with_just_one_parent();
}

AndriySvyryd
AndriySvyryd approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@AndriySvyryd AndriySvyryd merged commit b69c2f3 into dotnet:main May 31, 2021
@umitkavala umitkavala deleted the optional-dependent-null branch May 31, 2021 09:32
@ajcvickers ajcvickers mentioned this pull request Jul 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees

@AndriySvyryd AndriySvyryd

Labels
community-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umitkavala @AndriySvyryd @kavalau