Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated "How To Contribute" doc to include video from EF Core team #24839

Merged
merged 4 commits into from
May 7, 2021

Conversation

dannyjacosta
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The code builds and tests pass (verified by our automated build checks)

  • Commit messages follow this format
    Summary of the changes
    - Added a link to a video where Entity Framework Core team members guide you through the process of contributing and provide advise and good practices.

  • Tests for the changes have been added (for bug fixes / features)

  • Code follows the same patterns and style as existing code in this repo

Review the guidelines for contributing for more details.

Added a link to a video where Entity Framework Core team members guide you through the contributing process and provide advise and good practices.
Corrected type in my own commit
@dannyjacosta
Copy link
Contributor Author

Sorry for the non descriptive title. I didn't notice it was taken automatically from the branch name.

@dannyjacosta dannyjacosta changed the title Dannyjacosta enhanced doc 1 Updated "How To Contribute" doc to include video from EF Core team May 5, 2021
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
Accepting spelling corrections

Co-authored-by: Shay Rojansky <roji@roji.org>
@dannyjacosta dannyjacosta requested a review from roji May 6, 2021 22:32
@roji roji merged commit fe2e2ec into dotnet:main May 7, 2021
@roji
Copy link
Member

roji commented May 7, 2021

Thanks @dannyjacosta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants