Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate SQL syntax #24806

Merged
merged 1 commit into from
May 4, 2021
Merged

Conversation

lauxjpn
Copy link
Contributor

@lauxjpn lauxjpn commented Apr 29, 2021

Uses T-SQL for all raw queries in FromSqlQueryTestBase and ensures they are funneled through NormalizeDelimitersInRawString(), so provider specific delimiters are applied.

lauxjpn added a commit to lauxjpn/Pomelo.EntityFrameworkCore.MySql that referenced this pull request Apr 30, 2021
lauxjpn added a commit to lauxjpn/Pomelo.EntityFrameworkCore.MySql that referenced this pull request May 2, 2021
lauxjpn added a commit to lauxjpn/Pomelo.EntityFrameworkCore.MySql that referenced this pull request May 2, 2021
lauxjpn added a commit to PomeloFoundation/Pomelo.EntityFrameworkCore.MySql that referenced this pull request May 2, 2021
* Migrate to EF Core 6.0.0-preview4.

* Fix MySqlMigrationsModelDiffer.

* Fix MySqlSqlTranslatingExpressionVisitor (NotTranslatedExpressionType after visiting a SqlBinaryExpression).

* Fix MySqlSqlTranslatingExpressionVisitor.

* Implement support to return a single byte from a byte array/binary column by index and First() extension method.

* Implement explicit datetime/timestamp, date and time literals.

* Implement SQL Server based workaround for EXISTS(...LIMIT 0 OFFSET 0) bug in MySQL (MariaDB works fine).

* Fix tests.

* Implement MySqlNetTopologySuiteApiConsistencyTest.

* Implement MySqlApiConsistencyTest.

* Setup CI usage of .NET Core preview release.

* Skip failing FromSqlQuery test cases, until dotnet/efcore#24806 has been merged.

* Implement FieldsOnlyLoadMySqlTest.

* Implement DesignTimeMySqlTest.

* Implement ManyToManyFieldsLoadMySqlTest.

* Implement MySqlUpdateSqlGeneratorTest.

* Annotate tests, that are not supported for MariaDB.

* Fix tests with inaccurate orderings. (Should be fixed in EF Core.)

* Annotate tests, that require window functions support (relevant for MySQL < 8.0.0).
@roji roji merged commit 23343b1 into dotnet:main May 4, 2021
@lauxjpn lauxjpn deleted the fix/fromsqlquerytests_syntax branch May 4, 2021 17:36
lauxjpn added a commit to lauxjpn/Pomelo.EntityFrameworkCore.MySql that referenced this pull request Nov 9, 2021
lauxjpn added a commit to lauxjpn/Pomelo.EntityFrameworkCore.MySql that referenced this pull request Nov 9, 2021
lauxjpn added a commit to PomeloFoundation/Pomelo.EntityFrameworkCore.MySql that referenced this pull request Nov 9, 2021
* Remove remnants of workaround for dotnet/efcore#25127.

* Remove workaround for dotnet/efcore#24819.

* Remove workaround for dotnet/efcore#24806.

* Remove workaround for dotnet/efcore#19027.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants