Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

round 1 - model + mig + some tests #24562

Merged
merged 1 commit into from
Jun 4, 2021
Merged

round 1 - model + mig + some tests #24562

merged 1 commit into from
Jun 4, 2021

Conversation

maumar
Copy link
Contributor

@maumar maumar commented Apr 1, 2021

For now just metadata and create+ drop migration operations

@AndriySvyryd
Copy link
Member

You should also include the model snapshot changes (SqlServerAnnotationCodeGenerator) and tests (ModelSnapshotSqlServerTest)

bricelam
bricelam reviewed Apr 2, 2021
View reviewed changes
Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (I skimmed through the Migrations and Scaffolding code)

@ajcvickers ajcvickers mentioned this pull request Apr 8, 2021
Closed
@maumar
Copy link
Contributor Author

maumar commented May 28, 2021

new version up @AndriySvyryd @bricelam @smitpatel

@maumar maumar force-pushed the temporal_tables_draft1 branch 3 times, most recently from 7461ef5 to b7e49cb Compare June 2, 2021 20:37
@maumar
Temporal Tables - metadata and migrations part
e7c0b9d 
- added model builder APIs that allows mapping entity to a temporal table as well as related configuration
- added conventions and validation for entities mapped to temporal table
- added migration support for adding/removing/modifying entities mapped to a temporal table
- added model snapshot generation for entities mapped to temporal table
@maumar maumar merged commit e7c0b9d into main Jun 4, 2021
@maumar maumar deleted the temporal_tables_draft1 branch June 4, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji left review comments

@smitpatel smitpatel smitpatel left review comments

@bricelam bricelam bricelam left review comments

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maumar @AndriySvyryd @bricelam @smitpatel @roji