Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent lifetime and registration pattern for design-time services #24519

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Use consistent lifetime and registration pattern for design-time services #24519

merged 2 commits into from
Apr 15, 2021

Conversation

AndriySvyryd
Copy link
Member

No description provided.

bricelam
bricelam reviewed Mar 26, 2021
View reviewed changes
Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do a bit more testing to make sure this doesn't break existing apps, extensions, and providers.

src/EFCore.Design/Design/DesignTimeServiceCollectionExtensions.cs Show resolved Hide resolved
src/EFCore.SqlServer/Design/Internal/SqlServerDesignTimeServices.cs Show resolved Hide resolved
@AndriySvyryd AndriySvyryd changed the base branch from DesignTimeModel to main March 26, 2021 18:39
@AndriySvyryd
Copy link
Member Author

This is ready for review

@ajcvickers
Copy link
Member

@AndriySvyryd I'll take a look once @bricelam is happy.

@AndriySvyryd AndriySvyryd merged commit 99166b3 into main Apr 15, 2021
@AndriySvyryd AndriySvyryd deleted the DesignTimeServices branch April 15, 2021 19:23
@ajcvickers ajcvickers mentioned this pull request Apr 22, 2021
Closed
@AndriySvyryd AndriySvyryd mentioned this pull request Sep 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bricelam bricelam bricelam approved these changes

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

Assignees
No one assigned
Labels
providers-beware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndriySvyryd @ajcvickers @bricelam