Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiny nullability corrections #24389

Merged
merged 1 commit into from
Mar 13, 2021
Merged

Tiny nullability corrections #24389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/EFCore.Relational/Infrastructure/RelationalOptionsExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public virtual string? ConnectionString
/// <returns> A new instance with the option changed. </returns>
public virtual RelationalOptionsExtension WithConnectionString([CanBeNull] string? connectionString)
{
Check.NotEmpty(connectionString, nameof(connectionString));
Check.NullButNotEmpty(connectionString, nameof(connectionString));

var clone = Clone();

Expand All @@ -118,10 +118,8 @@ public virtual DbConnection? Connection
/// </summary>
/// <param name="connection"> The option to change. </param>
/// <returns> A new instance with the option changed. </returns>
public virtual RelationalOptionsExtension WithConnection([NotNull] DbConnection connection)
public virtual RelationalOptionsExtension WithConnection([CanBeNull] DbConnection? connection)
{
Check.NotNull(connection, nameof(connection));

var clone = Clone();

clone._connection = connection;
Expand Down