Microsoft.Data.Sqlite: Use Span overload of sqlite3_prepare #24331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfoidl
reviewed
Mar 6, 2021
| @@ -470,15 +471,19 @@ private IEnumerable<sqlite3_stmt> PrepareAndEnumerateStatements(Stopwatch timer) | |||
| { | |||
| DisposePreparedStatements(disposing: false); | |||
|
|
|||
| var byteCount = Encoding.UTF8.GetByteCount(_commandText); | |||
| var sql = new byte[byteCount + 1]; | |||
There was a problem hiding this comment.
Is it possible to use the ArrayPool here to further reduce the allocations?
Or if byteCount is small enough to stack-allocated the sql-buffer?
There was a problem hiding this comment.
I have bigger plans to use this as a cache key, so I’ll wait to do optimizations like this as part of that work.
Removes a lot of unnecessary allocations and conversions from utf8 Fixes dotnet#16202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a lot of unnecessary allocations and conversions from utf8
Fixes #16202
Here are some rough numbers from the Mixed Update Pipeline EF Core benchmark: