Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit order in case the database returns the records in different order. #24234

Merged
merged 2 commits into from
Mar 13, 2021
Merged

Explicit order in case the database returns the records in different order. #24234

merged 2 commits into from
Mar 13, 2021

Conversation

cincuranet
Copy link
Contributor

Explicit order in case the database returns the records in different order (i.e. Firebird returns different order).

@cincuranet
Copy link
Contributor Author

I was trying to keep the original test structure. Do you want me to do the change to AssertQuery?

@maumar
Copy link
Contributor

maumar commented Mar 13, 2021

@cincuranet yes, this will handle ordering and also allows for better re-use tests in the future. Long term goal is to convert all the query tests (that we can) to AssertQuery

@maumar maumar merged commit ddefb6f into dotnet:main Mar 13, 2021
@maumar
Copy link
Contributor

maumar commented Mar 13, 2021

@cincuranet thank you for the contribution!

@ajcvickers ajcvickers mentioned this pull request Mar 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maumar maumar maumar approved these changes

@roji roji Awaiting requested review from roji

Assignees

@smitpatel smitpatel

Labels
community-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cincuranet @maumar @ajcvickers @smitpatel