Move IRelationalModel extension methods to the interfaces #24205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
Issue19213_6
branch
from
4b60e6f
to
9b577a4
Compare
AndriySvyryd
commented
Feb 20, 2021
| { | ||
| model.ModelDependencies = Dependencies.ModelDependencies; |
There was a problem hiding this comment.
@roji Now I remember why the code was factored that way. I needed an atomic SetModelDependencies as this could be called from multiple threads and model initialization cannot be made reliably idempotent.
Suggestions?
There was a problem hiding this comment.
Changed this to block concurrent threads until initialization is finished and also store the result in the model (needed for #8258).
There was a problem hiding this comment.
Sorry, missed this mention... looks OK to me.
smitpatel
reviewed
Feb 22, 2021
| @@ -55,7 +55,7 @@ public sealed record ModelRuntimeInitializerDependencies | |||
| /// </summary> | |||
| [EntityFrameworkInternal] | |||
| public ModelRuntimeInitializerDependencies( | |||
| [NotNull] SingletonModelDependencies singletonModelDependencies, | |||
| [NotNull] RuntimeModelDependencies singletonModelDependencies, | |||
There was a problem hiding this comment.
variable name. Also property name below?
Rename SingletonModelDependencies to RuntimeModelDependencies Rename GetEntityTypes(Type) to FindEntityTypes(Type) Rename FindPrincipals() to GetPrincipals() Remove IModelCreationDependencies Fixes #19213
AndriySvyryd
force-pushed
the
Issue19213_6
branch
from
0e77ee3
to
04bdaa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
SingletonModelDependenciestoRuntimeModelDependenciesRename
GetEntityTypes(Type)toFindEntityTypes(Type)Rename
FindPrincipals()toGetPrincipals()Remove
IModelCreationDependenciesFixes #19213