Support binary columns with SQL Server FREETEXT/CONTAINS #24033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Feb 1, 2021
|
I know adding stuff to Northwind would end badly. @maumar @smitpatel suggestions on where this test should live? GearsOfWar? |
|
I am not happy yet. Following 2 files needs similar update for docs. For testbase, @maumar is the boss! |
|
@smitpatel next task! |
roji
commented
Feb 7, 2021
| CREATE FULLTEXT CATALOG GearsOfWar_FTC AS DEFAULT; | ||
| CREATE FULLTEXT INDEX ON Missions (BriefingDocument TYPE COLUMN BriefingDocumentFileExtension) KEY INDEX PK_Missions; | ||
|
|
||
| WAITFOR DELAY '00:00:03'; |
There was a problem hiding this comment.
Yes. Unfortunately there is some asynchronous process here, so if we run the tests too quickly after creating the full text catalog/index, we get back empty resullts (not an error, which is what you get when the catalog/index aren't created at all). 😡 😡 😡
maumar
approved these changes
Feb 9, 2021
Ali-YousefiTelori
pushed a commit
to Ali-YousefiTelori/EntityFrameworkCore
that referenced
this pull request
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23921