Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to #23761 - UseRelationalNulls causes subquery to include NOT IN (NULL, x) #23856

Merged
merged 1 commit into from
Jan 15, 2021

Commits on Jan 15, 2021

  1. Fix to #23761 - UseRelationalNulls causes subquery to include NOT IN …

    …(NULL, x)
    
    We do optimization which combines comparisons based on the same property into IN and NOT IN. Problem is that if the comparisons contain nulls, we add those into the list of IN values, generating queries like  a IN (1, 2, NULL). In normal circumstances, during null semantics processing we extract these nulls and produce correct IS NULL / IS NOT NULL calls, however when useRelationalNulls is enabled, we don't run null semantics visitor and therefore don't "fix" the IN expressions.
    
    Fix is to only apply the initial optimization for c# null semantics.
    
    Fixes #23761
    maumar committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    f70d12d View commit details
    Browse the repository at this point in the history