[5.0.3] InMemory: Skip over AsSingleQuery method #23818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #23759
Description
Relational providers have
AsSingleQueryoperator to evaluate query in single SQL scenario. The queryable method only exist for relational providers but when using InMemory provider for testing (multiple providers in same app scenario), the method throws translation error since InMemory provider doesn't understand the method. In 5.0, we added code to skipAsSplitQuerythis is similar method on the flipside.Customer Impact
Customers who are using
AsSingleQueryin their production code and using InMemory provider for testing will see test failures.How found
Customer reported on 5.0.1.
Test coverage
Manually verified. No test projects contains relational and inmemory provider together.
Regression?
No, AsSingleQuery is operator introduced in 5.0 only. The query fails on 5.0.0 too.
Risk
"Low", we would skip over a method which would fail anyway. The fuzzy string match is by-design since we don't have access to actual method which is defined in a different assembly. Plus, InMemory is supposed to be used for testing only.