Fix to #19994 - Query/Test: figure out how to represent shadow properties in expected result queries #23579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
suggested changes
Dec 8, 2020
There was a problem hiding this comment.
Please unique-fy the whole thing with expected query rewriter and shadow mappings.
Right now shadow mappings are on expected data which you are copying over to test base duplicating it.
Ideally the shadow property mapping should be on fixture base since that determines the model fixture is using. We could just apply shadow property mapping rewriter always and autoamatically without testbase asking for it.
smitpatel
reviewed
Dec 10, 2020
test/EFCore.Relational.Specification.Tests/Query/TPTGearsOfWarQueryRelationalFixture.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Dec 10, 2020
test/EFCore.Specification.Tests/Query/ComplexNavigationsSharedTypeQueryTestBase.cs
Show resolved
Hide resolved
smitpatel
reviewed
Dec 10, 2020
test/EFCore.Specification.Tests/Query/GearsOfWarQueryFixtureBase.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Dec 10, 2020
test/EFCore.Specification.Tests/TestModels/GearsOfWarModel/GearsOfWarData.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Dec 10, 2020
test/EFCore.Specification.Tests/TestUtilities/ExpectedQueryRewritingVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Dec 10, 2020
test/EFCore.Specification.Tests/TestUtilities/ExpectedQueryRewritingVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Dec 10, 2020
test/EFCore.Specification.Tests/TestUtilities/ExpectedQueryRewritingVisitor.cs
Outdated
Show resolved
Hide resolved
…ties in expected result queries Building the mapping in test fixtures - we need access to expected data so we also have access to navigations and entities for shadow navigations in the future. Fixes #19994
|
updated |
smitpatel
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the mapping when we generate the expected data, so we also have access to navigations and entities for shadow navigations in the future.
Discriminators are added at the test class level since we use same expected data setup for TPH and TPT.
Fixes #19994