-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EF.Functions.IsNumeric #23232
Merged
Merged
Add EF.Functions.IsNumeric #23232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
suggested changes
Nov 9, 2020
src/EFCore.SqlServer/Query/Internal/SqlServerIsNumericFunctionTranslator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.SqlServer/Query/Internal/SqlServerIsNumericFunctionTranslator.cs
Outdated
Show resolved
Hide resolved
RaymondHuy
force-pushed
the
issue23114
branch
from
November 13, 2020 16:58
8ed51fd
to
d639ff6
Compare
bricelam
approved these changes
Nov 30, 2020
smitpatel
reviewed
Nov 30, 2020
src/EFCore.SqlServer/Query/Internal/SqlServerMethodCallTranslatorProvider.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Nov 30, 2020
src/EFCore.SqlServer/Query/Internal/SqlServerIsNumericFunctionTranslator.cs
Show resolved
Hide resolved
RaymondHuy
force-pushed
the
issue23114
branch
from
December 2, 2020 04:08
7743378
to
7d0e98c
Compare
Hi @smitpatel @bricelam Are there anything else I need to change so that this PR can be merged ? |
@RaymondHuy - I will process this PR and merge it to master in a day or two. I don't believe we need anymore changes here. Thank for you contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #23114