Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EF.Functions.Random #23145

Merged
1 commit merged into from
Dec 22, 2020
Merged

Add EF.Functions.Random #23145

1 commit merged into from
Dec 22, 2020

Conversation

RaymondHuy
Copy link
Contributor

@RaymondHuy RaymondHuy commented Oct 30, 2020

Fix: #16141

Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are you interested in providing a base Relational implementation?

@smitpatel What's the best way to "override" the base implementation in SQLite?

@bricelam
Copy link
Contributor

if provider implements it differently then provider behavior will win

Does that mean they can just add a new provider-specific method translator and it will win?

@smitpatel
Copy link
Contributor

Does that mean they can just add a new provider-specific method translator and it will win?

Yes. The ordering is

  • User defined functions
  • Plugins
  • Provider translations
  • Relational translations

@RaymondHuy RaymondHuy force-pushed the issue-16141 branch 2 times, most recently from 888ad44 to 970ce71 Compare November 27, 2020 01:40
@RaymondHuy
Copy link
Contributor Author

Hi @smitpatel @bricelam Are there anything else I need to change so that this PR can be merged ?

@smitpatel
Copy link
Contributor

@RaymondHuy - I will process this PR and merge it to master in a day or two. I don't believe we need anymore changes here. Thank for you contribution.

@ghost
Copy link

ghost commented Dec 22, 2020

Hello @smitpatel!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Dec 22, 2020

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add EF.Functions.Random()
6 participants