Properly translate TimeSpan members for SqlServer and Sqlite #19643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… database translations.
|
|
|
Closing because #19617 seems to be a more complete solution that encompasses this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR allows TimeSpan members to be summed on SqlServer and Sqlite. There was previously an error because of missing IMemberTranslator classes. I am new to this repository, so I'm not 100% sure whether this is the optimal solution.
This is in response to #19360, but I don't think this fully closes the issue since this PR does not affect the behavior of non-SqlServer/Sqlite databases.