9.0.6 throws PendingModelChangesWarning with IdentityDbContext<T>

[MaximG1234]

Bug description

I have just upgraded my EF (identity) project to 9.0.6 and started running into the PendingModelChangesWarning error. In the process of debugging it I appear to have stumbled across what appears to be a bug in the implementation as it stands.

Not sure where this is most appropriate to log so I am going to log it both in EF core and the aspnetcore github.

Also this error message is awful, surely you can provide more information about specifically what is wrong?

Your code

The bug appears to be very easy to reproduce.

Create a new database context

`public sealed class DatabaseContextTest(DbContextOptions<DatabaseContextTest> options) : DbContext(options) {}`

run your first migrations:

`dotnet ef migrations add First_Migration`

Run: `await dbContext.Database.MigrateAsync();` 

Seems to work fine.

Modify this back to what I essentially had:

`public sealed class DatabaseContextTest(DbContextOptions<DatabaseContextTest> options) : IdentityDbContext(options) {}`

or more specifically 

`public sealed class DatabaseContextTest(DbContextOptions<DatabaseContextTest> options) : IdentityDbContext<ApplicationUser>(options) {}`

run your first migrations:

`dotnet ef migrations add First_Migration`

Run: `await dbContext.Database.MigrateAsync();` 

and you get: 

`An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'DatabaseContextTest' has pending changes. Add a new migration before updating the database. See https://aka.ms/efcore-docs-pending-changes. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.`

Stack traces

An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'DatabaseContextTest' has pending changes. Add a new migration before updating the database. See https://aka.ms/efcore-docs-pending-changes. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.

Verbose output

EF Core version

9.0.6

Database provider

Microsoft.EntityFrameworkCore.SqlServer

Target framework

.NET 9.0

Operating system

No response

IDE

Visual Studio 2022

[roji]

Please read #35285 thoroughly to understand what this warning means - it most likely indicates a problem in your own application's migrations.

[MaximG1234]

Hi @roji,

Thanks for your response but I don't think this is the case. As per my example above I am getting this with a new empty project, containing no prior migrations and an empty database. To the best of my knowledge there is nothing I have added which could cause this error, its occurring with a completely fresh setup only once I inherit from IdentityDbContext<T>.

I do encourage you to try it yourself.

[roji]

I'm unable to reproduce this. based on your instructions, I've written the following console program. Then, ensuring there are no existing migrations of any kind (blank project), I executed dotnet ef migrations add First_Migration - this worked without any error. Running the program then created the database as expected.

await using var context = new BloggingContextFactory().CreateDbContext([]);
await context.Database.EnsureDeletedAsync();
await context.Database.MigrateAsync();

public class DatabaseContextTest(DbContextOptions<DatabaseContextTest> options) : IdentityDbContext(options)
{
    protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        => optionsBuilder
            .UseSqlServer("Server=localhost;Database=test;User=SA;Password=Abcd5678;Connect Timeout=60;ConnectRetryCount=0;Encrypt=false")
            .LogTo(Console.WriteLine, LogLevel.Information)
            .EnableSensitiveDataLogging();
}

public class BloggingContextFactory : IDesignTimeDbContextFactory<DatabaseContextTest>
{
    public DatabaseContextTest CreateDbContext(string[] args)
    {
        var options = new DbContextOptionsBuilder<DatabaseContextTest>()
            .UseSqlServer("Server=localhost;Database=test;User=SA;Password=Abcd5678;Connect Timeout=60;ConnectRetryCount=0;Encrypt=false")
            .LogTo(Console.WriteLine, LogLevel.Information)
            .Options;

        return new DatabaseContextTest(options);
    }
}

[MaximG1234]

@roji , thank you for trying.

Your code is ever so slightly different to mine but nothing that looks like it should stop the error I encountered from appearing. I'll give it another attempt shortly and report back along with an example project if I am still able to reproduce.

Are you definitely using 9.0.6?

[MaximG1234]

Also in my example I am using integrated security, I doubt thats the cause but I will verify and again provide a full example project if I am able to reproduce.

[roji]

I'll give it another attempt shortly and report back along with an example project if I am still able to reproduce.

Sure thing. In the future, please always simply include such a minimal project in the initial report - that would really save lots of back-and-forths and my time spent on trying to put together the repro.

[MaximG1234]

@roji

Fair enough, I assumed it was a simple enough problem that there was no point, but as they say about assumptions... haha

After creating a new project based off my original code, I have been able to create a minimal example which reproduces the issue and it looks to be related to the following code:

builder.Services.AddDefaultIdentity<ApplicationUser>(options =>
    {
        options.SignIn.RequireConfirmedAccount = false;
    })
    .AddRoles<IdentityRole>()
    .AddEntityFrameworkStores<DatabaseContext>();

Please find a complete example attached to this post which should hopefully reproduce the issue for you.

WebTail.Cloud.Dashboard - Copy.zip

[MaximG1234]

Hi, just wondering if there is any progress on this?

[AndriySvyryd]

To use the Identity configuration when creating a migration you need to specify the startup project:
dotnet ef migrations add New --startup-project .\WebTail.Cloud.Dashboard\ --project .\WebTail.Cloud.Database\