`Sqlite:Autoincrement` is not generated for key column when the entity has owned property

[noelex]

Consider the following configuration:

public class SomeRandomEntity
{
    public long Id { get; set; }

    public OwnedEntity? Owned { get; set; }
}

public class OwnedEntity
{
    public int OwnedField { get; set; }
}

internal class ReproDbContext : DbContext
{
    protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
    {
        optionsBuilder.UseSqlite();
    }

    protected override void OnModelCreating(ModelBuilder modelBuilder)
    {
        modelBuilder.Entity<SomeRandomEntity>(entity =>
        {
            entity.HasKey(x => x.Id);
            entity.OwnsOne(x => x.Owned);
        });
    }
}

dotnet ef migrations add generates a migration with the following code:

migrationBuilder.CreateTable(
    name: "SomeRandomEntity",
    columns: table => new
    {
        Id = table.Column<long>(type: "INTEGER", nullable: false),
        Owned_OwnedField = table.Column<int>(type: "INTEGER", nullable: true)
    },
    constraints: table =>
    {
        table.PrimaryKey("PK_SomeRandomEntity", x => x.Id);
    });

Note that Sqlite:Autoincrement is missing on Id. This can be 'fixed' by either changing the name of the entity to MyEntity:

migrationBuilder.CreateTable(
    name: "MyEntity",
    columns: table => new
    {
        Id = table.Column<long>(type: "INTEGER", nullable: false)
            .Annotation("Sqlite:Autoincrement", true),
        Owned_OwnedField = table.Column<int>(type: "INTEGER", nullable: true)
    },
    constraints: table =>
    {
        table.PrimaryKey("PK_MyEntity", x => x.Id);
    });

or by removing Owned property:

migrationBuilder.CreateTable(
    name: "SomeRandomEntity",
    columns: table => new
    {
        Id = table.Column<long>(type: "INTEGER", nullable: false)
            .Annotation("Sqlite:Autoincrement", true)
    },
    constraints: table =>
    {
        table.PrimaryKey("PK_SomeRandomEntity", x => x.Id);
    });

Reverting Microsoft.EntityFrameworkCore.Sqlite and Microsoft.EntityFrameworkCore.Design to 6.0.33 also fixes the issue.

EF Core version: 8.0.8
Database provider: Microsoft.EntityFrameworkCore.Sqlite
Target framework: net-8.0

[cincuranet]

Note: Works correctly with Microsoft.EntityFrameworkCore.SqlServer. So probably SQLite provider specific.

[noelex]

efcore/src/EFCore.Sqlite.Core/Metadata/Internal/SqliteAnnotationProvider.cs

Line 68 in 90d0799

var property = column.PropertyMappings.First().Property;

This line might be problematic since PropertyMappings may contain a shadow ColumnMapping for the owned entity:

ColumnMapping: OwnedEntity.SomeRandomEntityId - SomeRandomEntity.Id
ColumnMapping: SomeRandomEntity.Id - SomeRandomEntity.Id

Things will only work when the first ColumnMapping happens to be the right one.

And these may also cause problems?

efcore/src/EFCore.Relational/Metadata/IColumn.cs

Lines 26 to 72 in 90d0799

	/// <summary>
	/// Gets the maximum length of data that is allowed in this column. For example, if the property is a <see cref="string" /> '
	/// then this is the maximum number of characters.
	/// </summary>
	int? MaxLength
	=> PropertyMappings.First().Property.GetMaxLength(StoreObjectIdentifier.Table(Table.Name, Table.Schema));
	/// <summary>
	/// Gets the precision of data that is allowed in this column. For example, if the property is a <see cref="decimal" /> '
	/// then this is the maximum number of digits.
	/// </summary>
	int? Precision
	=> PropertyMappings.First().Property.GetPrecision(StoreObjectIdentifier.Table(Table.Name, Table.Schema));
	/// <summary>
	/// Gets the scale of data that is allowed in this column. For example, if the property is a <see cref="decimal" /> '
	/// then this is the maximum number of decimal places.
	/// </summary>
	int? Scale
	=> PropertyMappings.First().Property.GetScale(StoreObjectIdentifier.Table(Table.Name, Table.Schema));
	/// <summary>
	/// Gets a value indicating whether or not the property can persist Unicode characters.
	/// </summary>
	bool? IsUnicode
	=> PropertyMappings.First().Property.IsUnicode(StoreObjectIdentifier.Table(Table.Name, Table.Schema));
	/// <summary>
	/// Returns a flag indicating whether the property is capable of storing only fixed-length data, such as strings.
	/// </summary>
	bool? IsFixedLength
	=> PropertyMappings.First().Property.IsFixedLength(StoreObjectIdentifier.Table(Table.Name, Table.Schema));
	/// <summary>
	/// Indicates whether or not this column acts as an automatic concurrency token by generating a different value
	/// on every update in the same vein as 'rowversion'/'timestamp' columns on SQL Server.
	/// </summary>
	bool IsRowVersion
	=> PropertyMappings.First().Property.IsConcurrencyToken
	&& PropertyMappings.First().Property.ValueGenerated == ValueGenerated.OnAddOrUpdate;
	/// <summary>
	/// Gets the column order.
	/// </summary>
	/// <value> The column order. </value>
	int? Order
	=> PropertyMappings.First().Property.GetColumnOrder(StoreObjectIdentifier.Table(Table.Name, Table.Schema));