Skip to content

Query/Test: when verifying translation error, force using AssertTranslationFailedWithDetails, when details are provided #34354

Open

Description

In our query tests we sometimes expect a translation to fail, and use AssertTranslationFailed method for that purpose. However, sometimes our pipeline provides additional details why the translation has failed and we should look at that also. We have AssertTranslationFailedWithDetails, but we should consider throwing when tests calls regular AssertTranslationFailed but there are details provided.

Need to see how noisy it's going to be, might be overkill, or we could just do a pass to fix some of the tests but don't force it on everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions