Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqliteConnectionFactory.cs is not thread-safe #26612

Closed
sebastienros opened this issue Nov 10, 2021 · 2 comments · Fixed by #26658
Closed

SqliteConnectionFactory.cs is not thread-safe #26612

sebastienros opened this issue Nov 10, 2021 · 2 comments · Fixed by #26658
Assignees
@roji
Labels
area-adonet-sqlite closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. Servicing-approved type-bug
Milestone
6.0.1

Comments

@sebastienros
Copy link
Member

Reads on the Dictionary are not locked with the write operations, which is not supported.
Suggestion is to use a ConcurrentDictionary and remove some of the locks, or use a ReaderWriterLockSlim.

https://github.com/dotnet/efcore/blob/main/src/Microsoft.Data.Sqlite.Core/SqliteConnectionFactory.cs#L53

c.f. Dictionary source that is can throw an exception if the collection was changed while reads occur.
https://source.dot.net/#System.Private.CoreLib/Dictionary.cs,398
@roji
Copy link
Member

roji commented Nov 10, 2021

/cc @bricelam

roji added a commit to roji/efcore that referenced this issue Nov 12, 2021
@roji
Use read-write lock to protect concurrent pool accesses
c5b0c1a 
Fixes dotnet#26612
@roji roji mentioned this issue Nov 12, 2021
Merged
roji added a commit to roji/efcore that referenced this issue Nov 12, 2021
@roji
Use read-write lock to protect concurrent pool accesses
88ac71a 
Fixes dotnet#26612
roji added a commit to roji/efcore that referenced this issue Nov 15, 2021
@roji
Use read-write lock to protect concurrent pool accesses (dotnet#26658)
643042c 
Fixes dotnet#26612
@roji roji mentioned this issue Nov 15, 2021
Merged
roji added a commit that referenced this issue Nov 15, 2021
@roji
Use read-write lock to protect concurrent pool accesses (#26658) (#26697
e5fb2fe 
)

Fixes #26612
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 15, 2021
@roji roji self-assigned this Nov 15, 2021
@ajcvickers ajcvickers added this to the 6.0.1 milestone Nov 16, 2021
@ajcvickers
Copy link
Member

FYI for those impacted by this issue: EF Core 6.0.1 is now available from NuGet.

@ajcvickers ajcvickers mentioned this issue Dec 16, 2021
Closed
@ajcvickers ajcvickers mentioned this issue Jan 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-adonet-sqlite closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. Servicing-approved type-bug
Projects
None yet
Milestone
6.0.1
Development

Successfully merging a pull request may close this issue.

[6.0.1] Use read-write lock to protect SQLite concurrent pool accesses roji/efcore
3 participants
@sebastienros @ajcvickers @roji