Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query/InMemory: projecting (int?)(myBaseEntity as MyDerivedEntity).IntOnDerived defaults to 0 rather than null #25735

Closed
maumar opened this issue Aug 26, 2021 · 0 comments · Fixed by #25968
Closed

Query/InMemory: projecting (int?)(myBaseEntity as MyDerivedEntity).IntOnDerived defaults to 0 rather than null #25735

maumar opened this issue Aug 26, 2021 · 0 comments · Fixed by #25968
Assignees
@smitpatel
Labels
area-in-memory area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
6.0.0

Comments

@maumar
Copy link
Contributor

maumar commented Aug 26, 2021

Slight discrepancy between InMemory and relational (and arguably L2O if we ignore the null ref) - since the actual property is int?, it should have defaulted to null, but instead we get 0 for InMemory
@ajcvickers ajcvickers added this to the 6.0.0 milestone Aug 27, 2021
@smitpatel smitpatel assigned smitpatel and unassigned maumar Sep 10, 2021
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Sep 10, 2021
smitpatel added a commit that referenced this issue Sep 10, 2021
@smitpatel
InMemory: Read nullable value for derived properties
9f6bc2a 
So that when that property is being read outside of entity materialization, we get null value rather than default of non-nullable type

Resolves #25735
@smitpatel smitpatel mentioned this issue Sep 10, 2021
Merged
smitpatel added a commit that referenced this issue Sep 13, 2021
@smitpatel
InMemory: Read nullable value for derived properties (#25968)
b6d45ab 
So that when that property is being read outside of entity materialization, we get null value rather than default of non-nullable type

Resolves #25735
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-rc2 Sep 14, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-rc2, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-in-memory area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

InMemory: Read nullable value for derived properties dotnet/efcore
3 participants
@ajcvickers @smitpatel @maumar