Closed
Description
February 19
Done
- Investigate removing
IModelCreationDependencies - Rename
SingletonModelDependenciestoRuntimeModelDependecies - Consider renaming
IConventionModel.GetEntityTypes(Type type);toFindEntityTypes - Rename
IConventionModel.FindPrincipalstoGetPrincipals - @AndriySvyryd Add
RelationalEntityTypeExtensions.FindRowInternalForeignKeysIEntityTypeoverload, and more generally have three overloads for each of these. - @AndriySvyryd
RelationalPropertyExtensions.FindOverridesmay not need a mutable overload
March 4
Done
- Change
Annotatable.IsReadonlytoReadOnly - Change
EnsureReadonlytoEnsureMutable - @ajcvickers Review template methods on
RelationalConnectionand removeDbConnectionState
March 24
Done
- Rename
DisableConcurrencyDetectiontoEnableThreadSafetyChecks - @bricelam Check that dropping
ITableMigrationOperationfromDropIndexOperationis expected. - Rename
IRelationalCommand.PopulateFromTemplatetoPopulateFrom - Rename parameter of above from
templateCommandtocommand
April 21
Done
- Move
DbContext.DesignTimeModeltoGetService<IDesignTimeModel>()or similar - @AndriySvyryd Consider making
ForeignKey.ReferencingSkipNavigationsreturn anISet - @AndriySvyryd Consider if
SlimModel.RelationalModelcan be made an explicit interface implementation and will still show up in the debugger. Also consider for DebugView.
June 16
Done
- @AndriySvyryd Make CSharpRuntimeAnnotationCodeGenerator and friends internal so we can add language-agnostic APIs later (Make ICSharpRuntimeAnnotationCodeGenerator language-agnostic #25110), try to move
ICSharpHelperback to .Design - @AndriySvyryd Make UpdateEntryEventData derive from DbContextEventData
- @AndriySvyryd Move more classes under the Microsoft.EntityFrameworkCore.Design namespace in Relational into the core assembly
- @AndriySvyryd Make RelationalCSharpRuntimeAnnotationCodeGenerator pubternal
- @ajcvickers Why did ContextParamaterBinding change to an array of IPropertyBase?
- Should it have params?
- @ajcvickers Review IRelationalCommandDiagnosticsLogger
- @smitpatel Remove IClonable from FromSqlExpression and TableExpression. Pattern match or introduce a new interface.
- Clone should return something more specific than
object
- Clone should return something more specific than
- @smitpatel Mitigate future breaks to SelectExpression. Mark more members as pubternal.
August 2
Done
- @roji Why is CoreOptionsExtension.DefaultLoggingCacheTime public? Make DefaultLoggingCacheTime private #25422
- @AndriySvyryd Rename IMutableModificationCommandFactory to just IModificationCommandFactory
- @AndriySvyryd Make ColumnModificationParameters and ModificationCommandParameters structs and use
in - @AndriySvyryd Rename IModificationCommand to IReadOnlyModificationCommand
- Rename IMutableModificationCommand to IModificationCommand
- @ajcvickers Move commandSource constructor parameters to the end in *EventData classes and IRelationalCommandDiagnosticsLogger
- @ajcvickers Address confusion beween AddSqlite and AddEntityFrameworkSqlite
- @maumar Make IQueryRootCreator a generic extensitiliby helper for nav expansion
- @maumar Can we mitigate timezone issues on TemporalAll/AsOf/etc methods?
- @maumar Rename With to Use in new methods on SqlServerEntityTypeBuilderExtensions
- @maumar Remove Temporal from new methods in SqlServerEntityTypeExtensions
- Keep it in the underlying annotation names
- @maumar Add Core and Relational dependency objects to SqlServerTemporalConvention
- @bricelam Move MigrationsBundle to the Migrations namespace
- Rename parameter to contextTypeName
- @bricelam Host API Review of CLI and PMC commands
August 18
- @bricelam Rename --bundle-runtime to --target-runtime
- Rename -Runtime to -TargetRuntime in PMC
- @bricelam Remove --bundle-configuration
- Make --configuration flow when Debug or Release Migration Bundles: Flow configuration from project #25906
- @bricelam Rename default bundle name to efbundle
- @AndriySvyryd Rename Scalars to DefaultTypeMapping
- Singularize methods in ScalarConfigurationBuilder and ScalarConfigurationBuilderExtensions
- @ajcvickers
Remove CosmosDbContextOptionsBuilder.HttpClientFactory and enable ReplaceService instead.Looked at this and talked to Andriy. It's quite complicated and somewhat ugly to do a service, so leaving as is. - @smitpatel Can we remove the override of TranslateSubquery in RelationalQueryableMethodTranslatingExpressionVisitor?
- @ajcvickers Revert ProviderCodeGenerator.RelationalDependencies to just Dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
