Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos: Distinct operator in queries #16144

Closed
smitpatel opened this issue Jun 19, 2019 · 4 comments · Fixed by #25505
Closed

Cosmos: Distinct operator in queries #16144

smitpatel opened this issue Jun 19, 2019 · 4 comments · Fixed by #25505
Assignees
@maumar
Labels
area-cosmos area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-enhancement
Milestone
6.0.0

Comments

@smitpatel
Copy link
Member

Test: Distinct
System.ArgumentException : Distict query requires a matching order by in order to return a continuation token.
If you would like to serve this query through continuation tokens, then please rewrite the query in the form 'SELECT DISTINCT VALUE c.blah FROM c ORDER BY c.blah' and please make sure that there is a range index on 'c.blah'.
@divega divega added this to the 3.0.0 milestone Jun 20, 2019
smitpatel added a commit that referenced this issue Jun 21, 2019
@smitpatel
Teeny tiny bugs
195faa0 
Part of #16133
Part of #16144
Resolves #16152
Part of #15662
@smitpatel smitpatel mentioned this issue Jun 21, 2019
Merged
smitpatel added a commit that referenced this issue Jun 21, 2019
@smitpatel
Teeny tiny bugs
ac13adf 
Part of #16133
Part of #16144
Resolves #16152
Part of #15662
smitpatel added a commit that referenced this issue Jun 21, 2019
@smitpatel
Teeny tiny bugs
bbd690b 
Part of #16133
Part of #16144
Resolves #16152
Part of #15662
smitpatel added a commit that referenced this issue Jun 21, 2019
@smitpatel
Teeny tiny bugs
4ddaff5 
Part of #16133
Part of #16144
Resolves #16152
Part of #15662
@smitpatel smitpatel removed this from the 3.0.0 milestone Jun 21, 2019
@ajcvickers ajcvickers assigned AndriySvyryd and unassigned smitpatel Jun 24, 2019
@ajcvickers ajcvickers added this to the 3.0.0 milestone Jun 24, 2019
@ajcvickers
Copy link
Member

To test on Cosmos.

@ajcvickers
Copy link
Member

@divega to look into order-by lifting.

@divega divega mentioned this issue Jun 24, 2019
Closed
@divega
Copy link
Contributor

divega commented Jun 24, 2019

Here is the original orderby lifting spec: #16226.

@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog Jun 28, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, MQ Sep 11, 2020
@ajcvickers ajcvickers assigned maumar and unassigned AndriySvyryd Sep 16, 2020
@ajcvickers ajcvickers removed this from the MQ milestone Sep 16, 2020
@ajcvickers ajcvickers added this to the Backlog milestone Sep 16, 2020
@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0 Nov 5, 2020
@smitpatel smitpatel removed this from the 6.0.0 milestone Nov 6, 2020
@smitpatel smitpatel removed the type-bug label Nov 6, 2020
@ajcvickers ajcvickers added verify-fixed This issue is likely fixed in new query pipeline. type-enhancement labels Nov 6, 2020
@ajcvickers ajcvickers added this to the MQ milestone Nov 6, 2020
@ajcvickers ajcvickers modified the milestones: MQ, 6.0.0 Dec 16, 2020
@ajcvickers ajcvickers mentioned this issue May 12, 2021
Closed
@ajcvickers ajcvickers mentioned this issue May 27, 2021
Closed
@maumar
Copy link
Contributor

maumar commented Aug 11, 2021

Basic Distinct scenarios work now. Many are blocked due to lack of subqueries, meaning we can't do pushdown (e.g. customers.Distinct().OrderBy()) or customers.Distinct().Count()

maumar added a commit that referenced this issue Aug 12, 2021
@maumar
Enabling some Distinct tests on Cosmos
9fbb296 
Resolves #16144
maumar added a commit that referenced this issue Aug 13, 2021
@maumar
Enabling some Distinct tests on Cosmos
3c9432e 
Resolves #16144
@maumar maumar mentioned this issue Aug 13, 2021
Merged
@maumar maumar added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed verify-fixed This issue is likely fixed in new query pipeline. labels Aug 13, 2021
maumar added a commit that referenced this issue Aug 13, 2021
@maumar
Enabling some Distinct tests on Cosmos
bf3ee7d 
Resolves #16144
maumar added a commit that referenced this issue Aug 13, 2021
@maumar
Enabling some Distinct tests on Cosmos
28bbe47 
Resolves #16144
@maumar maumar closed this as completed in 6eda37f Aug 13, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-rc1 Aug 14, 2021
@ajcvickers ajcvickers mentioned this issue Sep 23, 2021
Closed
@ajcvickers ajcvickers modified the milestones: 6.0.0-rc1, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
area-cosmos area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

[SMALL] Enabling some Distinct tests on Cosmos dotnet/efcore
5 participants
@divega @ajcvickers @smitpatel @maumar @AndriySvyryd