Review updates

dotnet · Sep 2, 2021 · b38e124 · b38e124
1 parent 2175510
commit b38e124
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/src/EFCore.Relational/Storage/CharTypeMapping.cs b/src/EFCore.Relational/Storage/CharTypeMapping.cs
@@ -25,7 +25,7 @@ public class CharTypeMapping : RelationalTypeMapping
         /// <param name="dbType"> The <see cref="DbType" /> to be used. </param>
         public CharTypeMapping(
             string storeType,
-            DbType? dbType = null) // No DbType for char
+            DbType? dbType = System.Data.DbType.String)
             : base(storeType, typeof(char), dbType)
         {
         }

diff --git a/src/EFCore.Relational/Storage/DateTimeTypeMapping.cs b/src/EFCore.Relational/Storage/DateTimeTypeMapping.cs
@@ -26,7 +26,7 @@ public class DateTimeTypeMapping : RelationalTypeMapping
         /// <param name="dbType"> The <see cref="DbType" /> to be used. </param>
         public DateTimeTypeMapping(
             string storeType,
-            DbType? dbType = System.Data.DbType.DateTime2)
+            DbType? dbType = System.Data.DbType.DateTime)
             : base(storeType, typeof(DateTime), dbType)
         {
         }

diff --git a/src/EFCore.SqlServer/Storage/Internal/SqlServerDateTimeTypeMapping.cs b/src/EFCore.SqlServer/Storage/Internal/SqlServerDateTimeTypeMapping.cs
@@ -43,7 +43,7 @@ public class SqlServerDateTimeTypeMapping : DateTimeTypeMapping
         /// </summary>
         public SqlServerDateTimeTypeMapping(
             string storeType,
-            DbType? dbType,
+            DbType? dbType = System.Data.DbType.DateTime2,
             StoreTypePostfix storeTypePostfix = StoreTypePostfix.Precision)
             : base(
                 new RelationalTypeMappingParameters(

diff --git a/src/EFCore.Sqlite.Core/Storage/Internal/SqliteDateTimeTypeMapping.cs b/src/EFCore.Sqlite.Core/Storage/Internal/SqliteDateTimeTypeMapping.cs
@@ -24,7 +24,7 @@ public class SqliteDateTimeTypeMapping : DateTimeTypeMapping
         /// </summary>
         public SqliteDateTimeTypeMapping(
             string storeType,
-            DbType? dbType = System.Data.DbType.DateTime2)
+            DbType? dbType = System.Data.DbType.DateTime)
             : base(storeType, dbType)
         {
         }

diff --git a/test/EFCore.Sqlite.FunctionalTests/Query/NorthwindWhereQuerySqliteTest.cs b/test/EFCore.Sqlite.FunctionalTests/Query/NorthwindWhereQuerySqliteTest.cs
@@ -49,7 +49,7 @@ public override async Task Where_datetime_now(bool async)
             await base.Where_datetime_now(async);
 
             AssertSql(
-                @"@__myDatetime_0='2015-04-10T00:00:00.0000000'
+                @"@__myDatetime_0='2015-04-10T00:00:00.0000000' (DbType = DateTime)
 
 SELECT ""c"".""CustomerID"", ""c"".""Address"", ""c"".""City"", ""c"".""CompanyName"", ""c"".""ContactName"", ""c"".""ContactTitle"", ""c"".""Country"", ""c"".""Fax"", ""c"".""Phone"", ""c"".""PostalCode"", ""c"".""Region""
 FROM ""Customers"" AS ""c""
@@ -61,7 +61,7 @@ public override async Task Where_datetime_utcnow(bool async)
             await base.Where_datetime_utcnow(async);
 
             AssertSql(
-                @"@__myDatetime_0='2015-04-10T00:00:00.0000000'
+                @"@__myDatetime_0='2015-04-10T00:00:00.0000000' (DbType = DateTime)
 
 SELECT ""c"".""CustomerID"", ""c"".""Address"", ""c"".""City"", ""c"".""CompanyName"", ""c"".""ContactName"", ""c"".""ContactTitle"", ""c"".""Country"", ""c"".""Fax"", ""c"".""Phone"", ""c"".""PostalCode"", ""c"".""Region""
 FROM ""Customers"" AS ""c""
@@ -86,7 +86,7 @@ public override async Task Where_datetime_date_component(bool async)
             await base.Where_datetime_date_component(async);
 
             AssertSql(
-                @"@__myDatetime_0='1998-05-04T00:00:00.0000000'
+                @"@__myDatetime_0='1998-05-04T00:00:00.0000000' (DbType = DateTime)
 
 SELECT ""o"".""OrderID"", ""o"".""CustomerID"", ""o"".""EmployeeID"", ""o"".""OrderDate""
 FROM ""Orders"" AS ""o""