Skip to content

Conversation

@lbussell
Copy link
Member

@lbussell lbussell commented Mar 5, 2025

Fixes #5020

@lbussell lbussell requested a review from a team as a code owner March 5, 2025 23:35
Copy link
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that #5020 shouldn't be closed until this is rolled out to main.

What is the plan for the .NET 8 & 9 AOT images in nightly?

Comment on lines +281 to +284
new() { Version = V10_0_Preview, Arch = Arch.Amd64, SdkImageVariant = DotNetImageVariant.AOT, SupportedImageRepos = DotNetImageRepo.Runtime_Deps, OS = OS.Alpine321 },
new() { Version = V10_0_Preview, Arch = Arch.Amd64, SdkImageVariant = DotNetImageVariant.AOT, SupportedImageRepos = DotNetImageRepo.Runtime_Deps, OS = OS.AzureLinux30Distroless, SdkOS = OS.AzureLinux30 },
new() { Version = V10_0_Preview, Arch = Arch.Amd64, SdkImageVariant = DotNetImageVariant.AOT, SupportedImageRepos = DotNetImageRepo.Runtime_Deps, OS = OS.NobleChiseled, SdkOS = OS.Noble },
new() { Version = V10_0_Preview, Arch = Arch.Amd64, SdkImageVariant = DotNetImageVariant.AOT, SupportedImageRepos = DotNetImageRepo.Runtime_Deps, OS = OS.TrixieSlim },
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just acknowledging here that I arranged these TestDatas in a different format in order to make it more obvious what was different between each entry. I didn't apply it to the whole file so that there wasn't a huge diff. We can apply that later to the rest of the file.

@lbussell
Copy link
Member Author

lbussell commented Mar 6, 2025

What is the plan for the .NET 8 & 9 AOT images in nightly?

AFAIK there are users using .NET 8 and 9 AOT nightly images in production. Because of that I don't think we can/should remove them.

I see our options as:

  1. Do nothing
  2. Port them to main as-is
  3. Port them to main in this new format we have for .NET 10
    • I imagine if we did this, we'd remove runtime-deps AOT images in nightly, but add the -aot tag as undocumented to the existing runtime-deps images so that users with those tags don't need to take any action.

@lbussell lbussell merged commit a918ada into dotnet:nightly Mar 6, 2025
120 of 121 checks passed
lbussell added a commit to lbussell/dotnet-docker that referenced this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants