Skip to content

fix msquic build on Alpine 3.16#931

Merged
wfurt merged 4 commits intomainfrom
alpine316
Nov 10, 2023
Merged

fix msquic build on Alpine 3.16#931
wfurt merged 4 commits intomainfrom
alpine316

Conversation

@wfurt
Copy link
Member

@wfurt wfurt commented Nov 8, 2023

this is follow-up on #923.
It seems like the image I cloned from was locked on release/7.0 so we are building really old msquic.
Since I'm touching this, I also removed dependency on PowerShell to get it on par with other architectures.
(we had to do it for ARM as PowerShell does not offer Alpine ARM binaries)

@wfurt
Copy link
Member Author

wfurt commented Nov 8, 2023

I added ldd as extra step. It should fail the build if the produced library is not loadable

bash-5.1$ ldd /usr/lib/libmsquic.so.2
	/lib/ld-musl-x86_64.so.1 (0x7fc4d84f9000)
	libcrypto.so.1.1 => /lib/libcrypto.so.1.1 (0x7fc4d8120000)
	libc.musl-x86_64.so.1 => /lib/ld-musl-x86_64.so.1 (0x7fc4d84f9000)
Error relocating /usr/lib/libmsquic.so.2: EVP_seed_cbc: symbol not found
bash-5.1$ echo $?
127

It should availed late surprised like dotnet/runtime#94487

Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wfurt wfurt merged commit de436ee into main Nov 10, 2023
@wfurt wfurt deleted the alpine316 branch November 10, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants