Skip to content

Add new image for Ubuntu 22.04/helix/webassembly #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 1, 2023

Conversation

radical
Copy link
Member

@radical radical commented Aug 17, 2023

No description provided.

@radical
Copy link
Member Author

radical commented Aug 21, 2023

@akoeplinger @mthalman is there any way of using the image generated in the CI build, on a test PR in dotnet/runtime so I can confirm that everything works? Or does the PR need to be merged first?

@mthalman
Copy link
Member

@akoeplinger @mthalman is there any way of using the image generated in the CI build, on a test PR in dotnet/runtime so I can confirm that everything works? Or does the PR need to be merged first?

No, the PR build from this repo doesn't cause any images to be stored that are referenceable externally. You would need to build it yourself, push it to a registry that you have access to, and update the PR to reference the registry location.

@radical radical force-pushed the add-wasm-helix-22.04 branch from 25ebda6 to 0d8ca31 Compare August 21, 2023 21:10
@radical radical force-pushed the add-wasm-helix-22.04 branch from 0d8ca31 to 8b8ed0b Compare August 23, 2023 04:31
@radical
Copy link
Member Author

radical commented Aug 23, 2023

I was able to test this by creating a container registry on azure, and using that to test the image on a PR in dotnet/runtime.

@radical radical requested a review from directhex August 23, 2023 04:33
@radical
Copy link
Member Author

radical commented Aug 23, 2023

Does curl -fsSL https://deb.nodesource.com/setup_18.x | bash - look acceptable for installing node, or should I download a tarball and use that? (and add any needed dependencies manually)

@radical radical requested a review from akoeplinger August 23, 2023 04:34
@radical radical changed the title Add src/ubuntu/22.04/helix/webassembly/Dockerfile Add new image for Ubuntu 22.04/helix/webassembly Aug 23, 2023
@radical radical requested review from pavelsavara and maraf August 23, 2023 04:39
@radical radical marked this pull request as ready for review August 23, 2023 04:56
@mthalman
Copy link
Member

Does curl -fsSL https://deb.nodesource.com/setup_18.x | bash - look acceptable for installing node, or should I download a tarball and use that? (and add any needed dependencies manually)

What does that do that installing nodejs doesn't do? Looking at other Dockerfiles in this repo, I see they just install nodejs.

@radical
Copy link
Member Author

radical commented Aug 23, 2023

Does curl -fsSL https://deb.nodesource.com/setup_18.x | bash - look acceptable for installing node, or should I download a tarball and use that? (and add any needed dependencies manually)

What does that do that installing nodejs doesn't do? Looking at other Dockerfiles in this repo, I see they just install nodejs.

This is the recommended way on nodejs.org (https://nodejs.org/en/download/package-manager#debian-and-ubuntu-based-linux-distributions). It adds apt sources, and then installs the package for that specific version, IIUC.

@directhex
Copy link
Contributor

nodejs in Ubuntu 22.04 is 12.22.9

We need a third party repo, or a from-source build, or I guess dogfooding our NuGet, for newer.

Ankit has followed the upstream instructions for installing newer. If we wanted we could extract the detail of what that's actually doing, to have a little less "pipe random downloads into root bash". It's a 400 line bash script which adds a relevant sources.list entry and GPG key to the system.

@radical
Copy link
Member Author

radical commented Sep 1, 2023

It's a 400 line bash script which adds a relevant sources.list entry and GPG key to the system.

I have extracted the relevant bits, and kept them in a separate file just so it is easier to update in future.

@radical radical requested a review from mthalman September 1, 2023 07:47
@mthalman mthalman merged commit a21b14d into dotnet:main Sep 1, 2023
@radical radical deleted the add-wasm-helix-22.04 branch September 1, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants