-
Notifications
You must be signed in to change notification settings - Fork 116
Add new image for Ubuntu 22.04/helix/webassembly #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@akoeplinger @mthalman is there any way of using the image generated in the CI build, on a test PR in |
No, the PR build from this repo doesn't cause any images to be stored that are referenceable externally. You would need to build it yourself, push it to a registry that you have access to, and update the PR to reference the registry location. |
25ebda6
to
0d8ca31
Compare
0d8ca31
to
8b8ed0b
Compare
I was able to test this by creating a container registry on azure, and using that to test the image on a PR in |
Does |
What does that do that installing |
This is the recommended way on nodejs.org (https://nodejs.org/en/download/package-manager#debian-and-ubuntu-based-linux-distributions). It adds apt sources, and then installs the package for that specific version, IIUC. |
We need a third party repo, or a from-source build, or I guess dogfooding our NuGet, for newer. Ankit has followed the upstream instructions for installing newer. If we wanted we could extract the detail of what that's actually doing, to have a little less "pipe random downloads into root bash". It's a 400 line bash script which adds a relevant sources.list entry and GPG key to the system. |
I have extracted the relevant bits, and kept them in a separate file just so it is easier to update in future. |
No description provided.