Skip to content

Add sudo, dotnet SDK build need this to reduce risk of sdk build failure #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

wli3
Copy link

@wli3 wli3 commented Feb 8, 2019

We (SDK) hope to add sudo to build in docker image. So we do not need to download during CI build to reduce build failure like this.

https://dev.azure.com/dnceng/public/_build/results?buildId=90582

cc @nguerrera

@wli3
Copy link
Author

wli3 commented Feb 8, 2019

@MichaelSimons

Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I just have one minor comment.

@MichaelSimons
Copy link
Member

@wli3 - Can you merge in latest and address the one comment so that the PR can get merged?

@wli3
Copy link
Author

wli3 commented Mar 12, 2019

Sorry for the delay just rebased

@wli3
Copy link
Author

wli3 commented Mar 12, 2019

@dotnet-bot test opensuse please

@wli3
Copy link
Author

wli3 commented Mar 12, 2019

opensuse failure seems unrelated. any idea?

@MichaelSimons
Copy link
Member

the opensuse failure is something that recently regressed because the base image is no longer available - #97.

@wli3
Copy link
Author

wli3 commented Mar 22, 2019

#97 is still opening. I will check a few days later again

@MichaelSimons
Copy link
Member

wli3 - can you sync with the latest? CI should be fixed now.

@wli3 wli3 force-pushed the add-sudo branch 3 times, most recently from 25e5645 to 8cfe5a7 Compare March 27, 2019 01:49
@wli3
Copy link
Author

wli3 commented Mar 27, 2019

Just updated

@MichaelSimons
Copy link
Member

Unfortunately debian:8 regressed today - see #107.

@MichaelSimons
Copy link
Member

@wli3 - The debian:8 issue was resolved. Can you please update the PR. I sure hope this is the last time 😃

@wli3
Copy link
Author

wli3 commented Mar 28, 2019

updated

@wli3
Copy link
Author

wli3 commented Mar 28, 2019

@MichaelSimons looks good. I don't have access to merge. Could you merge it?

@MichaelSimons MichaelSimons merged commit afc9dca into dotnet:master Mar 28, 2019
@MichaelSimons
Copy link
Member

The following images were built as a result of merging this PR:

mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-afc9dca-20190328175133
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-debpkg-cfdd435-20190328175133
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-17.10-afc9dca-20190328175132
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-17.10-debpkg-cfdd435-20190328175132
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-16.04-afc9dca-20190328175112
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-16.04-debpkg-cfdd435-20190328175112
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-16.04-coredeps-d770b8b-20190328175112
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-16.04-coredeps
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-16.04-crossdeps-cfdd435-20190328175112
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-16.04-crossdeps
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-16.04-cross-arm64-cfdd435-20190328175112
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-16.04-cross-arm64-alpine-cfdd435-20190328175112
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-16.04-cross-cfdd435-20190328175112
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-16.04-mlnet-207e097-20190328175112
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-14.04-afc9dca-20190328175106
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-14.04-debpkg-cfdd435-20190328175106
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-14.04-coredeps-4e6e894-20190328175106
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-14.04-coredeps
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-14.04-crossdeps-cfdd435-20190328175106
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-14.04-crossdeps
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-14.04-cross-cfdd435-20190328175106
mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-29-afc9dca-20190328175057
mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-29-helix-c6dc5e6-20190328175057
mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-28-afc9dca-20190328175057
mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-28-helix-45b1fa2-20190328175057
mcr.microsoft.com/dotnet-buildtools/prereqs:debian-jessie-coredeps-58e4974-20190328175052
mcr.microsoft.com/dotnet-buildtools/prereqs:debian-jessie-afc9dca-20190328175052
mcr.microsoft.com/dotnet-buildtools/prereqs:debian-jessie-debpkg-58e4974-20190328175052
mcr.microsoft.com/dotnet-buildtools/prereqs:debian-jessie-corert-58e4974-20190328175052
mcr.microsoft.com/dotnet-buildtools/prereqs:debian-stretch-docker-testrunner-63f2145-20190328175052
mcr.microsoft.com/dotnet-buildtools/prereqs:debian-stretch-afc9dca-20190328175052
mcr.microsoft.com/dotnet-buildtools/prereqs:opensuse-42.3-afc9dca-20190328191913
mcr.microsoft.com/dotnet-buildtools/prereqs:centos-7-afc9dca-20190328192013
mcr.microsoft.com/dotnet-buildtools/prereqs:centos-7-mlnet-8bba86b-20190328192013
mcr.microsoft.com/dotnet-buildtools/prereqs:centos-6-afc9dca-20190328192030

@wli3
Copy link
Author

wli3 commented Mar 28, 2019

Thanks!

@wli3 wli3 deleted the add-sudo branch March 28, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants