-
Notifications
You must be signed in to change notification settings - Fork 116
Add sudo, dotnet SDK build need this to reduce risk of sdk build failure #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I just have one minor comment.
b6d43f5
to
3a082fc
Compare
@wli3 - Can you merge in latest and address the one comment so that the PR can get merged? |
Sorry for the delay just rebased |
@dotnet-bot test opensuse please |
opensuse failure seems unrelated. any idea? |
the opensuse failure is something that recently regressed because the base image is no longer available - #97. |
#97 is still opening. I will check a few days later again |
wli3 - can you sync with the latest? CI should be fixed now. |
25e5645
to
8cfe5a7
Compare
Just updated |
Unfortunately debian:8 regressed today - see #107. |
@wli3 - The debian:8 issue was resolved. Can you please update the PR. I sure hope this is the last time 😃 |
updated |
@MichaelSimons looks good. I don't have access to merge. Could you merge it? |
The following images were built as a result of merging this PR:
|
Thanks! |
We (SDK) hope to add sudo to build in docker image. So we do not need to download during CI build to reduce build failure like this.
https://dev.azure.com/dnceng/public/_build/results?buildId=90582
cc @nguerrera