Skip to content

Add MsQuic to Ubuntu 20.04 Dockerfile #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Jul 11, 2024

@rzikm rzikm requested a review from a team as a code owner July 11, 2024 11:54
@rzikm rzikm requested a review from a team July 11, 2024 11:54
@am11
Copy link
Member

am11 commented Jul 11, 2024

@rzikm just curious, is it for 'testing on oldest supported Ubuntu' or 'any Ubuntu'? If it is latter, we can probably use 24.04 which will buy us couple of years until EOL.

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt wfurt merged commit 17c6f6e into dotnet:main Jul 11, 2024
33 checks passed
@wfurt
Copy link
Member

wfurt commented Jul 11, 2024

that may be historical reasons @am11. Msquic several times broke older versions as they focus only on tip of Ubuntu. (and run tests only there)
Ideally we would run tests on verity of Linux versions IMHO.

@rzikm rzikm deleted the ubuntu20-msquic branch July 12, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants