Skip to content

Add comments for new System.Net.Http.Json members #9302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

MihaZupan
Copy link
Member

Add comments for new System.Net.Http.Json members.

Contributes to dotnet/runtime#88569.

@MihaZupan MihaZupan requested a review from a team as a code owner September 18, 2023 14:30
@MihaZupan MihaZupan self-assigned this Sep 18, 2023
@ghost
Copy link

ghost commented Sep 18, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Add comments for new System.Net.Http.Json members.

Contributes to dotnet/runtime#88569.

Author: MihaZupan
Assignees: MihaZupan
Labels:

area-System.Net.Http

Milestone: -

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 68c9f18:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http.Json/HttpClientJsonExtensions.xml ✅Succeeded View
xml/System.Net.Http.Json/HttpContentJsonExtensions.xml ✅Succeeded View
xml/System.Net.Http.Json/JsonContent.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd provide suggestions to show the <see cref""/> for the jsonTypeInfo parameters but most of those docs predate this effort so I guess they can stay that way.

@carlossanlop carlossanlop merged commit c49dea0 into dotnet:main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants