Skip to content

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented Mar 15, 2021

Fixes #5408.

Internal preview link.

I reworded the first paragraph of the Remarks section. I added protected internal to the list of types/members extended by InternalsVisibleToAttribute. I also added a note about private protected per #5408.

cc @Youssef1313

@opbld30

This comment has been minimized.

@opbld33

This comment has been minimized.

@opbld31

This comment has been minimized.

@Youssef1313
Copy link
Member

Fixes dotnet/docs#5408.

This a PR. I think you may have copied the wrong link.

@gewarren
Copy link
Contributor Author

Fixes dotnet/docs#5408.

This a PR. I think you may have copied the wrong link.

Oops, that issue is actually in this repo. Thanks.

@opbld30

This comment has been minimized.

@gewarren gewarren changed the title Change private protected to protected internal Add clarification for private protected Mar 16, 2021
@gewarren gewarren closed this Mar 16, 2021
@gewarren gewarren reopened this Mar 16, 2021
@opbld33

This comment has been minimized.

@gewarren gewarren closed this Mar 16, 2021
@gewarren gewarren reopened this Mar 16, 2021
@opbld34
Copy link

opbld34 commented Mar 16, 2021

Docs Build status updates of commit e133f7f:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/InternalsVisibleToAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren
Copy link
Contributor Author

gewarren commented Apr 1, 2021

Ping for review?

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, one NIT comment

Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com>
@opbld33
Copy link

opbld33 commented Apr 5, 2021

Docs Build status updates of commit 8a3578a:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/InternalsVisibleToAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren merged commit 0e3ea7c into dotnet:main Apr 5, 2021
@gewarren gewarren deleted the protected-internal branch April 5, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InternalsVisibleToAttribute doesn't work for private protected access modifier

7 participants