Update ZipArchive.xml, ZipFile.xml #10193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed references to entryNameEncoding to clarify that it changes the encoding and decoding of both entry names and comments.
dotnet-policy-service
bot
added
the
community-contribution
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-io-compression |
|
Learn Build status updates of commit f67e849: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is an extension of dotnet/runtime#103271, feeding its documentation changes into this repo.
The current documentation for
ZipArchiveandZipFilereferences theentryNameEncodingparameter, describing it as being used to encode/decode ZIP archive entry names. This is incorrect; these two classes actually use this parameter to encode/decode ZIP entry names and comments.I've also made one change to ZipFile.xml on line 509. This previously said that if entry names and comments contained only ASCII characters, the language encoding flag would be set. This was backwards.