Added better exception to detect broken partition

dotnet · Jun 9, 2024 · 5e3f92e · 5e3f92e
1 parent b70aa9b
commit 5e3f92e
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/src/cluster/DotNext.Net.Cluster/ExceptionMessages.cs b/src/cluster/DotNext.Net.Cluster/ExceptionMessages.cs
@@ -56,4 +56,6 @@ internal static string UnknownRaftMessageType<T>(T messageType)
     internal static string LogEntryPayloadTooLarge => (string)Resources.Get();
 
     internal static string SparseFileNotSupported => (string)Resources.Get();
+
+    internal static string InvalidPartitionFormat => (string)Resources.Get();
 }
diff --git a/src/cluster/DotNext.Net.Cluster/ExceptionMessages.restext b/src/cluster/DotNext.Net.Cluster/ExceptionMessages.restext
@@ -19,4 +19,5 @@ UnknownRaftMessageType=Unknown Raft message type {0}
 PersistentStateBroken=Internal state of the WAL didn't pass the integrity check
 ConcurrentMembershipUpdate=Cluster membership cannot be modified concurrently
 LogEntryPayloadTooLarge=The size of the log entry is larger than specified threshold
-SparseFileNotSupported=TAR archive doesn't support sparse files on the target platform
+SparseFileNotSupported=TAR archive doesn't support sparse files on the target platform
+InvalidPartitionFormat=Partition has invalid binary format or broken
diff --git a/src/cluster/DotNext.Net.Cluster/Net/Cluster/Consensus/Raft/PersistentState.Partition.cs b/src/cluster/DotNext.Net.Cluster/Net/Cluster/Consensus/Raft/PersistentState.Partition.cs
@@ -508,6 +508,8 @@ internal override void Initialize()
         {
             using var handle = File.OpenHandle(FileName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite, FileOptions.SequentialScan);
 
+            long fileOffset;
+
             // read header
             if (RandomAccess.Read(Handle, header.Span, fileOffset: 0L) < HeaderSize)
             {
@@ -516,14 +518,18 @@ internal override void Initialize()
             else if (IsSealed)
             {
                 // partition is completed, read table
-                var tableStart = RandomAccess.GetLength(Handle);
-                RandomAccess.Read(Handle, footer.Span, tableStart - footer.Length);
+                fileOffset = RandomAccess.GetLength(Handle);
+
+                if (fileOffset < footer.Length + HeaderSize)
+                    throw new IntegrityException(ExceptionMessages.InvalidPartitionFormat);
+
+                fileOffset -= footer.Length;
+                RandomAccess.Read(Handle, footer.Span, fileOffset);
             }
             else
             {
                 // read sequentially every log entry
                 int footerOffset;
-                long fileOffset;
 
                 if (PartitionNumber is 0L)
                 {