Porting date and time topics from MSDN #992
Conversation
Previously reviewed - closes dotnet#224
|
testing close & reopen to trigger build. |
|
Open Publishing Build Service: The pull request content has been published and here are some sample preview links:
|
|
There's a bunch of warnings on the OPS build report. Our builds were clean this morning so probably this PR is introducing them. Once those are fixed, I can review this. |
|
Open Publishing Build Service: The pull request content has been published and here are some sample preview links:
|
|
Open Publishing Build Service: The pull request content has been published and here are some sample preview links:
|
|
Open Publishing Build Service: The pull request content has been published and here are some sample preview links:
|
| @@ -18,7 +18,7 @@ Successfully working with a designated time zone requires that information about | |||
|
|
|||
| ## To enumerate the time zones present on the local system | |||
|
|
|||
| 1. Call the [TimeZoneInfo.GetSystemTimeZones](xref:System.TimeZoneInfo.GetSystemTimeZones) method. The method returns a generic [ReadOnlyCollection<T>](xref:System.Collections.ObjectModel.ReadOnlyCollection%601) collection of [TimeZoneInfo](xref:System.TimeZoneInfo) objects. The entries in the collection are sorted by their [DisplayName](xref:System.TimeZoneInfo.DisplayName) property. For example: | |||
There was a problem hiding this comment.
this link was correct. you cannot use the url of the API for xref links, you need to use the uid which is found here: https://github.com/docascode/coreapi/
There was a problem hiding this comment.
so in this case, the uid is System.Collections.ObjectModel.ReadOnlyCollection`1. since you have a backtick, it needs to be encoded using %60.
|
Open Publishing Build Service: The pull request content has been published and here are some sample preview links:
|
|
Open Publishing Build Service: The pull request content has been published and here are some sample preview links:
|
|
Open Publishing Build Service: The pull request content has been published and here are some sample preview links:
|
|
@mairaw Build is clean and issues on stage resolved. |
|
|
||
| [Instantiating a DateTimeOffset Object](instantiating-a-datetimeoffset-object.md) - Discusses the ways in which a [System.DateTimeOffset](xref:System.DateTimeOffset) object can be instantiated, and the ways in which a [System.DateTime](xref:System.DateTime) value can be converted to a [System.DateTimeOffset](xref:System.DateTimeOffset) value. | ||
|
|
||
| [Performing Arithmetic Operations with Dates and Times]performing-arithmetic-operations.md) - Discusses the issues involved in adding, subtracting, and comparing [System.DateTime](xref:System.DateTime) and [System.DateTimeOffset](xref:System.DateTimeOffset) values. |
|
Did a quick review pass on stage and left some comments. |
|
Open Publishing Build Service: The pull request content has been published and here are some sample preview links:
|
|
@mairaw Addressed issues - ready to merge? |
| @@ -1,6 +1,6 @@ | |||
| --- | |||
| title: How to: access the predefined UTC and local time zone objects | |||
There was a problem hiding this comment.
We established as a pattern to enclose the title with quotes in these cases. See our style guide
|
Left one feedback about the metadata section. The rest of the changes looks good. |
|
Open Publishing Build Service: The pull request content has been published and here are some sample preview links:
|
|
@mairaw Fixed metadata in 6 files - good to go? |
|
That was my only comment, everything else looked good. |
Previously reviewed - closes #224